Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: enable gofumpt #3291

Merged
merged 2 commits into from
Apr 29, 2024
Merged

lint: enable gofumpt #3291

merged 2 commits into from
Apr 29, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 28, 2024

No description provided.

@zirain
lint: enable gofumpt
1677302 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from a team as a code owner April 28, 2024 06:55
@zirain
Copy link
Contributor Author

zirain commented Apr 28, 2024

/retest

@zhaohuabing
Copy link
Member

zhaohuabing commented Apr 29, 2024 •
edited
Loading

LGTM. But would we hold it for a while?
Many outstanding PRs need significant effort to rebase/merge because of the major changes in all the existing files.

@zirain
Copy link
Contributor Author

zirain commented Apr 29, 2024

LGTM. But would we hold it for a while? Many outstanding PRs need significant effort to rebase/merge because of the major changes in all the existing files.

anyone can run gofumpt -l -w . to fix locally.

@zirain zirain merged commit 5747123 into envoyproxy:main Apr 29, 2024
24 checks passed
@zirain zirain deleted the gofumpt branch April 29, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @zhaohuabing @shawnh2