Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stream info] [test] Fix broken StreamInfoImpl test #37619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

[stream info] [test] Fix broken StreamInfoImpl test #37619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/common/stream_info/stream_info_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,12 @@ class StreamInfoImplTest : public testing::Test {
protected:
void assertStreamInfoSize(StreamInfoImpl stream_info) {
ASSERT_TRUE(
sizeof(stream_info) == 840 || sizeof(stream_info) == 856 || sizeof(stream_info) == 888 ||
sizeof(stream_info) == 776 || sizeof(stream_info) == 728 || sizeof(stream_info) == 744 ||
sizeof(stream_info) == 680 || sizeof(stream_info) == 696 || sizeof(stream_info) == 688 ||
sizeof(stream_info) == 736 || sizeof(stream_info) == 728 || sizeof(stream_info) == 712 ||
sizeof(stream_info) == 704)
// with --config=docker-msan
sizeof(stream_info) == 712 ||
// with --config=docker-clang
sizeof(stream_info) == 720 ||
// with --config=docker-clang-libc++
sizeof(stream_info) == 688)
<< "If adding fields to StreamInfoImpl, please check to see if you "
"need to add them to setFromForRecreateStream or setFrom! Current size "
<< sizeof(stream_info);
Expand Down
1 change: 1 addition & 0 deletions tools/spelling/spelling_dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ ODCDS
middlewildcard
monostate
mpd
msan
mutators
mybucket
myobject
Expand Down