http2: less NO_ERROR #37270
Draft
http2: less NO_ERROR #37270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
|
CC @envoyproxy/runtime-guard-changes: FYI only for changes made to |
abeyad
reviewed
Nov 20, 2024
| @@ -375,6 +375,9 @@ message ResponseFlags { | |||
|
|
|||
| // Indicates a downstream remote codec level reset was received on the stream | |||
| bool downstream_remote_reset = 28; | |||
|
|
|||
| // Indicates the stream was reset with the NO_ERROR code. | |||
| bool reset_no_error = 29; | |||
There was a problem hiding this comment.
can we also update L274 to have [#next-free-field: 30] ?
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
|
/wait |
Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level:
Testing: updated tests
Docs Changes:
Release Notes: