Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a key resharing protocol #96

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Jan 3, 2024

A part of #20. Not closing it yet since I'm not certain it's the best protocol to use, and it needs to be properly integrated with the rest of the framework. Also there is one pathway where a possible error is not attributable to any party - can be avoided by assuming that each party has access to public parts of keyshares of other nodes.

Merging this now because it has grown pretty big. Still more work needed to close the mentioned issues.

Public:

Internal:

Copy link

vercel bot commented Jan 3, 2024

@fjarri is attempting to deploy a commit to the entropyxyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synedrion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 5:02am

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (01c94b0) 86.48% compared to head (2cafdfc) 87.18%.
Report is 2 commits behind head on master.

Files Patch % Lines
synedrion/src/cggmp21/protocols/key_resharing.rs 88.30% 40 Missing ⚠️
synedrion/src/cggmp21/protocols/threshold.rs 89.61% 8 Missing ⚠️
synedrion/src/sessions/states.rs 80.00% 8 Missing ⚠️
synedrion/src/sessions/type_erased.rs 94.54% 3 Missing ⚠️
synedrion/src/cggmp21/protocols/generic.rs 97.75% 2 Missing ⚠️
synedrion/src/cggmp21/protocols/test_utils.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   86.48%   87.18%   +0.70%     
==========================================
  Files          44       45       +1     
  Lines        6644     7251     +607     
==========================================
+ Hits         5746     6322     +576     
- Misses        898      929      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjarri fjarri force-pushed the key-resharing branch 2 times, most recently from e734616 to e04d225 Compare January 15, 2024 07:11
@fjarri fjarri marked this pull request as ready for review January 16, 2024 00:48
@fjarri fjarri merged commit 3b789b0 into entropyxyz:master Jan 16, 2024
8 checks passed
@fjarri fjarri deleted the key-resharing branch January 16, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant