Don't use slice indexing #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 93.44% 93.16% -0.28%
==========================================
Files 34 34
Lines 6849 7026 +177
==========================================
+ Hits 6400 6546 +146
- Misses 449 480 +31 ☔ View full report in Codecov by Sentry. |
fjarri
reviewed
Dec 9, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
fjarri
reviewed
Dec 11, 2024
| pub type U2048Mod = MontyForm<{ nlimbs!(2048) }>; | ||
| pub type U4096Mod = MontyForm<{ nlimbs!(4096) }>; | ||
| // TODO(dp): Suggest crypto-bigint update nlimbs! macro. | ||
| pub type U512Mod = MontyForm<{ 512u32.div_ceil(Limb::BITS) as usize }>; |
There was a problem hiding this comment.
This is not necessary, I pinned Rust version for the clippy CI action, it now runs on 1.81.
There was a problem hiding this comment.
We'll soon have to bump to 1.83 yeah? And I run clippy locally and it complains.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
clippy::indexing_slicinglint in all non-test code. Also changes some methods to returnResult.Closes #68