-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Fermionic QAOA(FQAOA) Module and Associated Files into OpenQAOA #322
base: dev
Are you sure you want to change the base?
Integrate Fermionic QAOA(FQAOA) Module and Associated Files into OpenQAOA #322
Conversation
633f28e
to
31da142
Compare
I've just pushed an additional notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on the implementation! While the PR is pretty big I think you still managed to get something really neat and relatively easy to review.
The documentation is really helpful, you did a great lot of work on this!
There are a few typos I commented on, and other minor changes I'd like you to implement. Feel free to discuss on the comments directly.
Also note that I don't know some of the functions like Givens rotation related algorithms, I trust that you implemented them correctly.
Thank you for your review and the kind words! I will pay particular attention to the functions, such as givens rotation, to make sure that they are correct. Thanks again for your time and valuable feedback! |
Thank you for the detailed review! I've pushed a new commit that addresses the typos and minor corrections as per your comments. Here's a summary of the changes:
Please note that the error mitigation SPAM twiling is still pending and will be tackled in a separate commit. I've also performed a final spell check using |
386824e
to
3769a86
Compare
3769a86
to
9c607cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! I would only like to sort out the issue with the docs and a couple of tiny comments I left.
…ected incorrect usage of np.ndarray for np.array in the code.
…epare is_close_statevector for potential move to utilities.py
84df030
to
db9001b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two final comments, it seems good otherwise!
I want to express my sincere gratitude for your incredibly detailed review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to address all the comments I made there. Happy to help anytime!
The PR looks good to me! Just need to remove this temporary file to make sure the docs pipeline passes.
I've added a risk factor to the objective function and updated the related tests. Integrate risk factor into objective function and update related tests
|
Description
This pull request introduces the FQAOA (Fermionic Quantum Approximate Optimization Algorithm) module along with its associated files into the OpenQAOA framework. The integration includes the following components:
test_workflows.py: Tests the overall workflow integration, confirming that FQAOA integrates smoothly with existing components.
All tests have been successfully executed, demonstrating the stability and effectiveness of the integrated features. This addition enhances the OpenQAOA framework by introducing the capability to handle constrained combinatorial optimization problems using FQAOA.
Checklist
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The following unit tests have been added to ensure the robustness and accuracy of the new features:
test_fqaoa.py: Tests the core functionality of the fqaoa_utils.py.
test_workflows.py: Validates the integration of fqaoa_workflow.py within the overall workflow.
test_analytical_simulator.py: Confirms the exception handling in the FQAOA approach.