Skip to content

Commit

Permalink
chore: Don't Type Check .d.ts Files
Browse files Browse the repository at this point in the history
The TypeScript type checker is now throwing
errors when we check types with the
`skipLibCheck: false` configuration. It seems
that one of the packages that we installed along
the way started causing this problem... Vitest
definitely seems to be a culprit. We can't
ignore this anymore since we're thinking about
adding linting to CI.

Generally speaking, this should be fine. But
we DO want to make sure that our LOCAL `.d.ts`
files are accurate. So... if necessary, we may
occasionally need to make this flag `false`
to make sure things are behaving as expected --
unless we find that TS will still check our
LOCAL `.d.ts` files.

In an ideal world, we could define all of our
types in JS files. Hopefully that day comes
eventually. Then we wouldn't need to worry
about this problem either way. 😄
  • Loading branch information
ITenthusiasm committed Dec 28, 2023
1 parent 3a13749 commit ebfa731
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"declaration": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"skipLibCheck": false
"skipLibCheck": true
},
// TODO: Split Vitest Config out from final production bundle ... EDIT: Depends on comment above
"include": ["packages/**/*", "scripts/**/*", "vitest.config.ts", "vitest.workspace.ts"]
Expand Down

0 comments on commit ebfa731

Please sign in to comment.