Skip to content

Commit

Permalink
chore: Enable Test for autoObserve in Solid Integration
Browse files Browse the repository at this point in the history
The test actually _was not_ failing due to a
bug in Vitest or Solid Testing Library. This
test was actually (rightly) failing because of
solidjs/solid-docs#278. This bug has been fixed
by fdf61ed.
  • Loading branch information
ITenthusiasm committed Nov 5, 2023
1 parent 7104248 commit 686c207
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions packages/solid/__tests__/createFormValidityObserver.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,7 @@ describe("Create Form Validity Observer (Function)", () => {

describe("Returned Interface", () => {
describe("autoObserve (Method)", () => {
// TODO: This test is currently broken because of issues either with `@solidjs/testing-library` or `vitest` or both.
// This test is important, but unfortunately it's impossible right now. Let's see what we can do in the future.
// eslint-disable-next-line vitest/no-disabled-tests
it.skip("Automatically sets up the `FormValidityObserver` (onMount) and cleans it up (onUnmount)", async () => {
it("Automatically sets up the `FormValidityObserver` (onMount) and cleans it up (onUnmount)", async () => {
/* ---------- Setup ---------- */
const message = "Only numbers are allowed!";
vi.spyOn(FormValidityObserver.prototype, "observe");
Expand Down

0 comments on commit 686c207

Please sign in to comment.