Support additional cred attributes #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
b393ae9
to
8174d04
Compare
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
647c8b3
to
ba548d2
Compare
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
ba548d2
to
2170d4c
Compare
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
a3b79eb
to
8d53a4c
Compare
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
fab8d20
to
903d7e7
Compare
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
638d5a6
to
38b490c
Compare
This is a cleanup commit. The code is still not fully functional.
Use parameterized to group tests
- Augment tests to detect issue - Update cffi backend to fix memory issues - Cleanup and remove unused global variables
Conoslidate the C definitions of the cffi backend into a single module to avoid redefinitions
itziakos
force-pushed
the
support-additional-cred-attributes
branch
from
38b490c
to
11588db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #105
Note: Currently only a single credential_attribute is supported when writing credentials