Add keyboard shortcuts for toolbar actions #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there someone assigned as the gatekeeper for pyface? @rkern: Could you review or suggest someone for review? |
|
While this would be the correct thing to do, i suspect it may break many applications which use same action in toolbar and menubar, since now Qt would start showing ambiguous shortcut overload warnings. |
|
I suggest not to push this in 4.5.0 as the idea of 4.5.0 is to get a stable released version for the apps like Canopy that are currently working out of master. |
|
I find that I often end up with two versions of an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QMenu.addAction has a key-sequence argument in it's signature, but QToolBar.addAction doesn't, so the initialization of keyboard shortcuts is a bit different.