-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require apptools 5.3 or later, Python 3.8 or later #584
Conversation
It looks as though the tests are failing on EDM due to an incorrect version for |
|
@flongford This PR should get us the green tick back on PR #580. |
The PR title and description were misleading about the actual goal of this PR; I've updated them. |
There's a required check for Python 3.7 that will need to be removed before merging. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the apptools dependency to apptools >= 5.3, and deals with various pieces of fallout from that change:
Detailed changes:
apptools >= 5.3
, which contains some fixes that we need for some upcoming bugfixes on this repository (see Fix premature writing of preferences #583)apptools[preferences]
rather than just plainapptools
, since version 5.3.0 ofapptools
no longer declaresconfigobj
as an explicit dependency, and Envisage preferences depend onconfigobj
configobj
explicitly inetstool.py
, since EDS doesn't support optional requirementsapptools
now also requires Python >= 3.8, andapptools >= 5.3.0
is not available for Python 3.7