Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require apptools 5.3 or later, Python 3.8 or later #584

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jul 15, 2024

This PR updates the apptools dependency to apptools >= 5.3, and deals with various pieces of fallout from that change:

Detailed changes:

  • require apptools >= 5.3, which contains some fixes that we need for some upcoming bugfixes on this repository (see Fix premature writing of preferences #583)
  • require apptools[preferences] rather than just plain apptools, since version 5.3.0 of apptools no longer declares configobj as an explicit dependency, and Envisage preferences depend on configobj
  • similarly, require configobj explicitly in etstool.py, since EDS doesn't support optional requirements
  • require Python >= 3.8, since apptools now also requires Python >= 3.8, and apptools >= 5.3.0 is not available for Python 3.7

@mdickinson
Copy link
Member Author

It looks as though the tests are failing on EDM due to an incorrect version for importlib_resources. I've opened an upstream issue.

@mdickinson
Copy link
Member Author

importlib_resources has been fixed upstream. Re-running the tests.

@mdickinson mdickinson changed the title Drop support for Python 3.7 Drop support for Python 3.7 and add explicit configobj dependency Jul 16, 2024
@mdickinson
Copy link
Member Author

@flongford This PR should get us the green tick back on PR #580.

@mdickinson mdickinson changed the title Drop support for Python 3.7 and add explicit configobj dependency Require apptools 5.3 or later Jul 16, 2024
@mdickinson
Copy link
Member Author

The PR title and description were misleading about the actual goal of this PR; I've updated them.

@mdickinson mdickinson changed the title Require apptools 5.3 or later Require apptools 5.3 or later, Python 3.8 or later Jul 16, 2024
@mdickinson
Copy link
Member Author

There's a required check for Python 3.7 that will need to be removed before merging.

@mdickinson
Copy link
Member Author

There's a required check for Python 3.7 that will need to be removed before merging.

Done.

Copy link

@flongford flongford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdickinson mdickinson merged commit 9c520cc into main Jul 17, 2024
11 checks passed
@mdickinson mdickinson deleted the dev/drop-support-for-python37 branch July 17, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants