Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equality check in TVTK-related test #352

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jul 4, 2024

Closes #305.

Ideally we'd install Mayavi into the test environment in the test workflows, but I think that's too much of a maintenance risk. It would be even better to find a way to remove the TVTK-specific specializations altogether.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

@mdickinson mdickinson merged commit ba20222 into main Jul 4, 2024
24 checks passed
@mdickinson mdickinson deleted the fix/array-comparison-in-tvtk-test branch July 4, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when mayavi 4.7.4 (with VTK 9.1.0) is in the same environment
1 participant