Avoid writing to preferences on helper creation #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
PreferencesHelper
to avoid writing to the preferences the first time a helper is created for a givenPreferences
object.The issue was that on creation,
PreferencesHelper._initialize
was being called twice: once withnotify=False
and again withnotify=True
, as a result of the listener to thepreferences
trait. This PR avoids the second call by making that listener only run post creation (usingpost_init=True
).Closes #342
Closes #74
Checklist