Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workers flag to validate input command #2218

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

robnester-rh
Copy link
Contributor

This commit reworks the concurrency model of validate input to be like that found in validate image. This commit adds a --workers flag, with a default of 5 that can be used to configure how many simultaneous fetches occur. This avoids situations where validating multiple input files can trigger HTTP 429 errors.

This commit reworks the concurrency model of `validate input` to be like
that found in `validate image`. This commit adds a `--workers` flag,
with a default of 5 that can be used to configure how many simultaneous
fetches occur. This avoids situations where validating multiple input
files can trigger HTTP 429 errors.

Signed-off-by: robnester-rh <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (9110d5f) to head (9abf08b).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
cmd/validate/input.go 91.89% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
+ Coverage   71.19%   72.42%   +1.22%     
==========================================
  Files          88       88              
  Lines        7520     7539      +19     
==========================================
+ Hits         5354     5460     +106     
+ Misses       2166     2079      -87     
Flag Coverage Δ
generative 72.42% <91.89%> (+1.22%) ⬆️
integration 72.42% <91.89%> (+1.22%) ⬆️
unit 72.42% <91.89%> (+1.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/validate/input.go 89.80% <91.89%> (+47.55%) ⬆️

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests. 👍 LGTM

@robnester-rh robnester-rh merged commit 684702d into enterprise-contract:main Dec 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants