Track the policy data by source group

[joejstuart]

Only collect the policy data once for each source group. Before this the data was duplicated for each component.

https://issues.redhat.com/browse/EC-1027

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.18%. Comparing base (d99dec0) to head (44e6b62).
Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/validate/input.go	0.00%	10 Missing ⚠️
cmd/validate/image.go	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
- Coverage   71.22%   71.18%   -0.05%     
==========================================
  Files          89       88       -1     
  Lines        7479     7506      +27     
==========================================
+ Hits         5327     5343      +16     
- Misses       2152     2163      +11     

Flag	Coverage Δ
generative	71.18% <57.14%> (-0.05%)	⬇️
integration	71.18% <57.14%> (-0.05%)	⬇️
unit	71.18% <57.14%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/image/validate.go	69.53% <100.00%> (+0.40%)	⬆️
internal/output/output.go	88.26% <ø> (ø)
cmd/validate/image.go	91.54% <84.61%> (-0.30%)	⬇️
cmd/validate/input.go	41.36% <0.00%> (-1.35%)	⬇️

... and 10 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[zregvart]

I'm expecting snapshots that need updating (haven't looked at the CI), so UPDATE_SNAPS=1 make ci should help

[zregvart]

Could be a tad nicer

Suggested change

	out.Data[fmt.Sprintf("%d", idx)] = append(out.Data[fmt.Sprintf("%d", idx)], data)
	key := strconv.FormatInt(idx, 10)
	out.Data[key] = append(out.Data[key], data)

[zregvart]

The snapshot variable substitution is somewhat rudimentary, I think we either need to indent by 2 or decrease the indent by 2, and the underscores should probably reflect that here

[lcarva]

I don't think this is quite right. This is merging all the data from different source groups.

Consider something like this:

// Renamed from manyData
var evaluatorData []evaluator.Data
dataCollected := false

for i := 0; i < numComponents; i++ {
  r := <-results
  ...
  if !dataCollected {
    evaluatorData = r.data
    dataCollected = true
  }
}

[lcarva]

or rather:

// Renamed from manyData
var evaluatorData []evaluator.Data

for i := 0; i < numComponents; i++ {
  r := <-results
  ...
  if evaluatorData == nil {
    evaluatorData = r.data
  }
}

Anyways, I think you get the idea.

[joejstuart]

Don't we want that since the data could differ per source group?

[lcarva]

r.data is a list of data.

[joejstuart]

I changed it to map[string]evaluator.Data. My thought was each evaluator maps to a source group, so to just collect data per evaluator.
https://github.com/enterprise-contract/ec-cli/pull/2181/files#diff-7f11215ba891ff8199fa09a412849a5414e416050d163c813f6499009bbe0b96R304
https://github.com/enterprise-contract/ec-cli/pull/2181/files#diff-ed62eb280d370e54af87c7fdb7026890b2efeefd1da359a2b28ecb76904cd86eR136

[lcarva]

hmm I think I see understand what you're doing now. Why use a map where the keys are indexes? Wouldn't it be more natural to keep it as a slice?

Also, running this for loop for every component is unnecessary. It's just copying data around needlessly. Please consider introducing a mechanism so that is only done for the first component.

[joejstuart]

This makes me think this whole PR could be replaced with

--- a/cmd/validate/image.go
+++ b/cmd/validate/image.go
@@ -410,7 +410,9 @@ func validateImageCmd(validate imageValidationFunc) *cobra.Command {
                                        allErrors = errors.Join(allErrors, e)
                                } else {
                                        components = append(components, r.component)
-                                       manyData = append(manyData, r.data)
+                                       if len(manyData) == 0 {
+                                               manyData = append(manyData, r.data)
+                                       }
                                        manyPolicyInput = append(manyPolicyInput, r.policyInput)
                                }
                        }

[joejstuart]

Closing in favor of this #2184