-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builtin experiments #1463
base: main
Are you sure you want to change the base?
Builtin experiments #1463
Conversation
This is helpful for some experiments I'm working on, and seems like a good enough tidy/refactor anyhow.
Should rebase on #1462 once that one is merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
+ Coverage 80.35% 87.16% +6.80%
==========================================
Files 66 77 +11
Lines 4674 5009 +335
==========================================
+ Hits 3756 4366 +610
+ Misses 918 643 -275
Flags with carried forward coverage won't be shown. Click here to find out more. |
e2629ff
to
8449e1f
Compare
8449e1f
to
56255d8
Compare
Will clean it up later. This demos slsa3 passing with ec validate input.
d88c9c0
to
a93ec19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an experiment. It's probably worth having it.
# limitations under the License. | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth adding a comment to explain what this experiment is.
It would be great to either close this PR or update it so it can be merged. |
Not sure if we want to merge this or not, but it's interesting to consider.
The idea is that maybe we move all out sigstore signature checks into rego and use ec validate input for everything.
Running the script looks like this: