EC-237 Add validate input and use policy config #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
- Coverage 84.31% 82.43% -1.89%
==========================================
Files 67 72 +5
Lines 5338 5721 +383
==========================================
+ Hits 4501 4716 +215
- Misses 837 1005 +168
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Run |
|
I think you need to rebase from main to get rid of the linting errors. |
Thanks, but this is failing locally. I had rebased before pushing...but I'll check it again. |
robnester-rh
force-pushed
the
EC-237
branch
2 times, most recently
from
6306bc1 to
c135d8c
Compare
lcarva
reviewed
Dec 11, 2023
|
robnester-rh
force-pushed
the
EC-237
branch
2 times, most recently
from
e9b139b to
6aa6a86
Compare
|
/retest |
1 similar comment
|
/retest |
lcarva
reviewed
Dec 14, 2023
This commit addresses EC-237 & EC-57 which marks `ec validate definition` as deprecated, adds `ec validate input` and allows `ec validate input` to utilize a policy config file in a similar manner as the `ec validate image` command.
lcarva
approved these changes
Dec 14, 2023
robnester-rh
merged commit 0c22525
into
enterprise-contract:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses EC-237 & EC-57 which marks
ec validate definitionas deprecated, addsec validate inputand allowsec validate inputto utilize a policy config file in a similar manner as theec validate imagecommand.