Add bash script to help fork a release branch #1203
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 67 67
Lines 5338 5338
=======================================
Hits 4501 4501
Misses 837 837
Flags with carried forward coverage won't be shown. Click here to find out more. |
hack/cut-release.sh
Outdated
| echo RHTAP application name: $RHTAP_APPLICATION_NAME | ||
|
|
||
| echo "Creating branch" | ||
| git checkout -b $BRANCH_NAME main |
There was a problem hiding this comment.
Do we need to make sure we have the latest upstream rev? git fetch upstream and git checkout -b $BRANCH_NAME upstream/main
There was a problem hiding this comment.
Yeah, maybe it's better not to rely on the human to have done it.
hack/cut-release.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| BRANCH_NAME="redhat-${RELEASE_NAME}" |
There was a problem hiding this comment.
Could we not call it redhat-*? What would be the downside of that?
There was a problem hiding this comment.
I think it communicates to a random person looking at our repo what the branch is for. But other than that, not much.
There was a problem hiding this comment.
How about release-* instead?
There was a problem hiding this comment.
In the new version it's just v0.1-whatever, no prefix at all.
hack/cut-release.sh
Outdated
| echo "Modifying pipelines" | ||
|
|
||
| for p in .tekton/*.yaml; do | ||
| # It would be nice to use yq here, but the formatting and indenting changes are too annoying |
There was a problem hiding this comment.
Why not format the YAML files in .tekton first then?
There was a problem hiding this comment.
Yeah, it's a reasonable idea.
|
This is no good actually. The component name is significant, since the pipeline definition file has a component name in it. So we have to copy the pipeline rather than modify it in place. |
simonbaird
force-pushed
the
cut-release-bash-script
branch
from
486bbe7 to
64a8772
Compare
|
Push a new revision where we let TAP create the pipeline definition. |
Ignore all the TAP pipelines for license preamble checking, not just the one specific one.
simonbaird
force-pushed
the
cut-release-bash-script
branch
from
64a8772 to
e1a5b6d
Compare
As mentioned in the comments, we could make this more automated in future. For now it's mostly a set of instructions for the human. The key part is to establish the procedure and the naming conventions.
simonbaird
force-pushed
the
cut-release-bash-script
branch
from
e1a5b6d to
e45bc08
Compare
No description provided.