Add the name property
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarva
approved these changes
Sep 21, 2023
zregvart
force-pushed
the
issue/HACBS-2468
branch
from
fc50286 to
b04a826
Compare
|
Should also resolve #31 |
zregvart
force-pushed
the
issue/HACBS-2468
branch
from
b04a826 to
0d8f870
Compare
Refactors the `src/data.json` to be an object instead of an array, this way the keys are guaranteed to be unique. Separates the notion of the directory vs name, now the directory (key in the top level object) can be different than the name. Ref. https://issues.redhat.com/browse/HACBS-2468
zregvart
force-pushed
the
issue/HACBS-2468
branch
from
0d8f870 to
f3c8017
Compare
|
This should be safe to merge now. |
lcarva
approved these changes
Sep 29, 2023
|
Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
src/data.jsonto be an object instead of an array, this way the keys are guaranteed to be unique. Separates the notion of the directory vs name, now the directory (key in the top level object) can be different than the name.Ref. https://issues.redhat.com/browse/HACBS-2468