Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start implementing hooks #21

Merged
merged 7 commits into from
Sep 24, 2020
Merged

start implementing hooks #21

merged 7 commits into from
Sep 24, 2020

Conversation

lache-melvin
Copy link
Contributor

I was messing with this last night... are there plans on how we'll do forms?

@lache-melvin lache-melvin requested a review from don-smith August 29, 2020 22:47
@don-smith
Copy link
Contributor

We haven't made any decisions on using any external form packages. While I've heard good things about https://react-hook-form.com from Suzana I'm not crazy that it uses ref. Dunno yet.

I've taken a light pass over your changes and they look great! 😍

@lache-melvin lache-melvin linked an issue Sep 23, 2020 that may be closed by this pull request
@don-smith don-smith merged commit 27e5cb2 into dev Sep 24, 2020
@don-smith don-smith deleted the hooks branch September 24, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace class-based component state with React Hooks
2 participants