Make .eth token ID change when fuses are burned #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to eliminate the risk of a frontrunning attack that burns fuses on a name just prior to transfer, this design changes the token ID when a fuse is burned - burning the old token and issuing a new one representing the name with the fuse burned.
Doing this breaks the assumption that token IDs are the
keccak256
hashes of names, so we have to make a few changes:RegistryDatastore
masks out the lower 32 bits of all IDs on storage and retrieval; two keys that differ only in these bits are treated as the same key.subregistryLocked
andresolverLocked
fuses in the lower 2 bits of the ID.AccessDenied
,InvalidSubregistryFlags
,InvalidResolverFlags
,renew
,lock
,setSubregistry
.ETHRegistry.register
, we separate out the flags and expiration date into separate fields.setResolver
method.