Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concatenate multiple text fields #332

Open
wants to merge 21 commits into
base: fix/refactor-wrapped-callback
Choose a base branch
from

Conversation

mdtanrikulu
Copy link
Contributor

No description provided.

contracts/dnsregistrar/OffchainDNSResolver.sol Outdated Show resolved Hide resolved
contracts/dnsregistrar/OffchainDNSResolver.sol Outdated Show resolved Hide resolved
@mdtanrikulu mdtanrikulu requested a review from Arachnid August 20, 2024 14:39
@mdtanrikulu mdtanrikulu marked this pull request as ready for review August 20, 2024 14:41
@mdtanrikulu mdtanrikulu requested a review from Arachnid November 12, 2024 12:53
Copy link
Member

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a couple of suggestions to tidy the code up.

contracts/dnsregistrar/OffchainDNSResolver.sol Outdated Show resolved Hide resolved
contracts/dnsregistrar/OffchainDNSResolver.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants