-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L2 reverse registrar contract #265
base: dev
Are you sure you want to change the base?
Changes from 28 commits
23c4a72
c763636
21c5d36
29fb8d7
7d632cb
0c67b45
1e464bd
27854e4
669081c
fea6ecb
4ef442f
c9274e3
de9959a
a104c83
2b66f4f
7530428
37eeec4
eea2bd9
569f07a
d25e521
5ed5fa9
369cc4a
6ed6d5f
4136a75
26fc75a
4ab3a85
3c93765
9bfdad0
6a86103
dfb000d
dc6e94d
9eb42f1
cbba61f
3b9e8d7
27ad314
d2315a9
a97255a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
pragma solidity >=0.8.4; | ||
|
||
interface IL2ReverseRegistrar { | ||
function setName(string memory name) external returns (bytes32); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need to return There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This point still stands There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original reverseRegistrar does this: https://github.com/ensdomains/ens-contracts/blob/staging/contracts/reverseRegistrar/IReverseRegistrar.sol There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it the contract you added several months ago? What was the intention at that time? If it's wrong then it should be fixed now unless it requires some sort of complex migration work as the change itself is not so critical |
||
|
||
function setNameForAddr( | ||
address addr, | ||
string memory name | ||
) external returns (bytes32); | ||
|
||
function setNameForAddrWithSignature( | ||
address addr, | ||
string memory name, | ||
uint256 inceptionDate, | ||
bytes memory signature | ||
) external returns (bytes32); | ||
|
||
function setNameForAddrWithSignatureAndOwnable( | ||
address contractAddr, | ||
makoto marked this conversation as resolved.
Show resolved
Hide resolved
|
||
address owner, | ||
string memory name, | ||
uint256 inceptionDate, | ||
bytes memory signature | ||
) external returns (bytes32); | ||
|
||
function setText( | ||
string calldata key, | ||
string calldata value | ||
) external returns (bytes32); | ||
|
||
function setTextForAddr( | ||
address addr, | ||
string calldata key, | ||
string calldata value | ||
) external returns (bytes32); | ||
|
||
function setTextForAddrWithSignature( | ||
address addr, | ||
string calldata key, | ||
string calldata value, | ||
uint256 inceptionDate, | ||
bytes memory signature | ||
) external returns (bytes32); | ||
|
||
function setTextForAddrWithSignatureAndOwnable( | ||
address contractAddr, | ||
address owner, | ||
string calldata key, | ||
string calldata value, | ||
uint256 inceptionDate, | ||
bytes memory signature | ||
) external returns (bytes32); | ||
|
||
function clearRecords(address addr) external; | ||
|
||
function clearRecordsWithSignature( | ||
address addr, | ||
uint256 inceptionDate, | ||
bytes memory signature | ||
) external; | ||
|
||
function node(address addr) external view returns (bytes32); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be added to .gitignore.