Update contracts/dnsregistrar/OffchainDNSResolver.sol

Co-authored-by: Nick Johnson <[email protected]>
ensdomains · Nov 15, 2024 · 4630340 · 4630340
1 parent 7654735
commit 4630340
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/contracts/dnsregistrar/OffchainDNSResolver.sol b/contracts/dnsregistrar/OffchainDNSResolver.sol
@@ -207,13 +207,11 @@ contract OffchainDNSResolver is IExtendedResolver, IERC165 {
         }
 
         bytes memory result = new bytes(totalLength);
-        idx = startIdx;
         uint256 resultIdx = 0;
-        while (idx < lastIdx) {
+        for (uint256 idx = startIdx; idx < lastIdx; idx += fieldLength + 1) {
             uint256 fieldLength = data.readUint8(idx);
             result.strcpy(resultIdx, data, idx + 1, fieldLength);
             resultIdx += fieldLength;
-            idx += fieldLength + 1;
         }
         return result;
     }