Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add header/banner spec #50

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

mdtanrikulu
Copy link
Contributor

@mdtanrikulu mdtanrikulu commented Sep 12, 2024

the PR introduces getHeader method to retrieve ens headers/banners, based on the same spec written for the avatar text record.

Method interface;

interface HeaderRequestOpts {
  jsdomWindow?: any;                 // required for any environment other than browser
  mediaKey?: 'header' | 'banner';    // both "header" and "banner" text records are supported. (default: header)
}

getHeader(ens: string, data: HeaderRequestOpts): Promise<string | null>;

Copy link

github-actions bot commented Sep 12, 2024

size-limit report 📦

Path Size
dist/index.js 170.46 KB (-0.38% 🔽)
dist/index.esm.js 58.25 KB (-2.02% 🔽)

.catch(console.log);

avt
.getHeader(ensName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually need this? Looks like it's just for debugging purpose doing console.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a simple debug example for nodejs.

@mdtanrikulu mdtanrikulu merged commit 54fcdfe into mdt/restricted-content-type Sep 26, 2024
7 checks passed
@mdtanrikulu mdtanrikulu deleted the mdt/get-header branch September 26, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants