fix some (not all) icon passings

ensdomains · Dec 8, 2024 · 5d723e2 · 5d723e2
1 parent 7c5664c
commit 5d723e2
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 18 deletions.
diff --git a/src/components/@atoms/PseudoActionButton/PseudoActionButton.test.tsx b/src/components/@atoms/PseudoActionButton/PseudoActionButton.test.tsx
@@ -14,7 +14,7 @@ afterAll(() => {
 
 describe('PseudoActionButton', () => {
   it('should show loading state when clicked and reset after timeout has been run', async () => {
-    const testIcon = <div data-testid="icon" />
+    const testIcon =() => <div data-testid="icon" />
     render(
       <PseudoActionButton prefix={testIcon} timeout={500}>
         Test
@@ -35,7 +35,7 @@ describe('PseudoActionButton', () => {
   })
 
   it('should maintain loading state if loading is set to true', async () => {
-    const testIcon = <div data-testid="icon" />
+    const testIcon = ()=> <div data-testid="icon" />
     render(
       <PseudoActionButton loading prefix={testIcon} timeout={500}>
         Test

diff --git a/src/components/@molecules/NameTableHeader/NameTableHeader.tsx b/src/components/@molecules/NameTableHeader/NameTableHeader.tsx
@@ -216,7 +216,7 @@ export const NameTableHeader = ({
           value={searchQuery}
           onChange={(e) => onSearchChange?.(e.target.value)}
           hideLabel
-          icon={<MagnifyingGlassSimpleSVG />}
+          icon={MagnifyingGlassSimpleSVG}
           placeholder={t('action.search')}
         />
       </TableHeaderTrailing>

diff --git a/src/components/@molecules/ProfileEditor/Avatar/AvatarNFT.tsx b/src/components/@molecules/ProfileEditor/Avatar/AvatarNFT.tsx
@@ -443,7 +443,7 @@ export const AvatarNFT = ({
           </Button>
         ))}
       <DialogInput
-        icon={<MagnifyingGlassSVG />}
+        icon={MagnifyingGlassSVG}
         hideLabel
         label="search"
         value={searchedInput}

diff --git a/src/components/ProfileSnippet.tsx b/src/components/ProfileSnippet.tsx
@@ -233,7 +233,7 @@ export const ProfileSnippet = ({
         <Button
           size="small"
           colorStyle="accentSecondary"
-          prefix={<FastForwardSVG />}
+          prefix={FastForwardSVG}
           data-testid="extend-button"
           onClick={() => {
             showExtendNamesInput(`extend-names-${name}`, {

diff --git a/src/components/pages/profile/[name]/Profile.tsx b/src/components/pages/profile/[name]/Profile.tsx
@@ -88,7 +88,7 @@ export const NameAvailableBanner = ({
       <Banner
         alert="info"
         as="a"
-        icon={<CheckCircleSVG />}
+        icon={CheckCircleSVG}
         title={t('banner.available.title', { name: normalisedName })}
       >
         <Trans

diff --git a/src/components/pages/profile/[name]/registration/steps/Profile/AddProfileRecordView.tsx b/src/components/pages/profile/[name]/registration/steps/Profile/AddProfileRecordView.tsx
@@ -280,7 +280,7 @@ export const AddProfileRecordView = ({ control, onAdd, onClose, showDismiss }: P
       <DialogInput
         label=""
         hideLabel
-        icon={<MagnifyingGlassSimpleSVG />}
+        icon={MagnifyingGlassSimpleSVG}
         size="medium"
         placeholder={t('action.search', { ns: 'common' })}
         value={search}

diff --git a/src/components/pages/profile/[name]/registration/steps/Profile/Profile.tsx b/src/components/pages/profile/[name]/registration/steps/Profile/Profile.tsx
@@ -321,7 +321,7 @@ const Profile = ({ name, callback, registrationData, resolverExists }: Props) =>
             size="medium"
             onClick={handleShowAddRecordModal}
             data-testid="show-add-profile-records-modal-button"
-            prefix={<PlusSVG />}
+            prefix={PlusSVG}
           >
             {t('steps.profile.addMore')}
           </Button>

diff --git a/src/components/pages/profile/settings/PrimarySection.tsx b/src/components/pages/profile/settings/PrimarySection.tsx
@@ -186,7 +186,7 @@ export const PrimarySection = () => {
                     buttonId="disabled-reset-primary-name-button"
                     buttonText={t('action.remove', { ns: 'common' })}
                     content={t('errors.networkError.blurb', { ns: 'common' })}
-                    prefix={<CrossSVG />}
+                    prefix={CrossSVG}
                     size="medium"
                     mobilePlacement="top"
                     loading={hasGraphErrorLoading}
@@ -195,7 +195,7 @@ export const PrimarySection = () => {
                     buttonId="disabled-change-primary-name-button"
                     buttonText={t('action.change', { ns: 'common' })}
                     content={t('errors.networkError.blurb', { ns: 'common' })}
-                    prefix={<PersonPlusSVG />}
+                    prefix={PersonPlusSVG}
                     size="medium"
                     mobilePlacement="top"
                     loading={hasGraphErrorLoading}
@@ -205,7 +205,7 @@ export const PrimarySection = () => {
                 <>
                   <Button
                     data-testid="reset-primary-name-button"
-                    prefix={<CrossSVG />}
+                    prefix={CrossSVG}
                     colorStyle="redSecondary"
                     disabled={hasGraphErrorLoading}
                     loading={hasGraphErrorLoading}
@@ -215,7 +215,7 @@ export const PrimarySection = () => {
                   </Button>
                   <Button
                     data-testid="change-primary-name-button"
-                    prefix={<PersonPlusSVG />}
+                    prefix={PersonPlusSVG}
                     disabled={hasGraphErrorLoading}
                     loading={hasGraphErrorLoading}
                     onClick={changePrimary}
@@ -236,7 +236,7 @@ export const PrimarySection = () => {
                   buttonText={t('section.primary.choosePrimaryName')}
                   size="small"
                   content={t('errors.networkError.blurb', { ns: 'common' })}
-                  prefix={<PersonPlusSVG />}
+                  prefix={PersonPlusSVG}
                   mobilePlacement="top"
                   loading={hasGraphErrorLoading}
                 />
@@ -246,7 +246,7 @@ export const PrimarySection = () => {
                 <NoNameButton
                   data-testid="set-primary-name-button"
                   size="small"
-                  prefix={<PersonPlusSVG />}
+                  prefix={PersonPlusSVG}
                   loading={hasGraphErrorLoading}
                   disabled={hasGraphErrorLoading}
                   onClick={changePrimary}

diff --git a/src/pages/my/names.tsx b/src/pages/my/names.tsx
@@ -43,7 +43,7 @@ export default function Page() {
               target="_blank"
               rel="noopener noreferrer"
               href="https://support.ens.domains/en/articles/9375254-why-is-my-ens-name-not-in-my-names"
-              icon={<QuestionCircleSVG />}
+              icon={QuestionCircleSVG}
               title={t('offchainWarning.title')}
             >
               {t('offchainWarning.text')}

diff --git a/src/transaction-flow/input/EditRoles/views/EditRoleView/EditRoleView.tsx b/src/transaction-flow/input/EditRoles/views/EditRoleView/EditRoleView.tsx
@@ -58,7 +58,7 @@ export const EditRoleView = ({ index, onBack }: Props) => {
           label="Role"
           size="medium"
           hideLabel
-          icon={<MagnifyingGlassSimpleSVG />}
+          icon={MagnifyingGlassSimpleSVG}
           clearable
           value={query}
           placeholder={t('input.sendName.views.search.placeholder')}

diff --git a/src/transaction-flow/input/ProfileEditor/ProfileEditor-flow.tsx b/src/transaction-flow/input/ProfileEditor/ProfileEditor-flow.tsx
@@ -326,7 +326,7 @@ const ProfileEditor = ({ data = {}, transactions = [], dispatch, onDismiss }: Pr
                     size="medium"
                     onClick={handleShowAddRecordModal}
                     data-testid="show-add-profile-records-modal-button"
-                    prefix={<PlusSVG />}
+                    prefix={PlusSVG}
                   >
                     {t('steps.profile.addMore')}
                   </Button>

diff --git a/src/transaction-flow/input/SendName/views/SearchView/SearchView.tsx b/src/transaction-flow/input/SendName/views/SearchView/SearchView.tsx
@@ -44,7 +44,7 @@ export const SearchView = ({ name, senderRole, onCancel, onSelect }: Props) => {
         label="Name"
         size="medium"
         hideLabel
-        icon={<MagnifyingGlassSimpleSVG />}
+        icon={MagnifyingGlassSimpleSVG}
         clearable
         {...register('query', {
           onChange: (e) => {