fix: min_commitment_age language #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gskril
approved these changes
Dec 3, 2024
5ajaki
added a commit
to 5ajaki/ENS-docs
that referenced
this pull request
Dec 15, 2024
* Patch L2 Reverse Name Link (ensdomains#355) * Misc. fixes and improvements to "Resolvers" section (ensdomains#357) * Typo corrections (ensdomains#345) * Add clarity about resolution starting from L1 (ensdomains#360) * fix: incorrect resolver address on EthRegistryDemo (ensdomains#368) Co-authored-by: Greg <[email protected]> * fix: min_commitment_age language (ensdomains#367) * Bump cross-spawn from 7.0.3 to 7.0.6 in /app (ensdomains#366) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update connect modal (ensdomains#340) * Create EP 5.27 (ensdomains#373) * Fix DAO stewards' avatars (ensdomains#363) * Add EP 5.22 (ensdomains#343) Co-authored-by: Greg Skriloff <[email protected]> * Bump nanoid from 3.3.7 to 3.3.8 in /app (ensdomains#374) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump secp256k1 from 5.0.0 to 5.0.1 in /app (ensdomains#335) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add EP 5.25 (ensdomains#358) Co-authored-by: Greg Skriloff <[email protected]> * Add EP 5.26 (ensdomains#359) Co-authored-by: Greg Skriloff <[email protected]> * Add EP 5.23 (ensdomains#376) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Luc van Kampen <[email protected]> Co-authored-by: r4bbit <[email protected]> Co-authored-by: Dmitry <[email protected]> Co-authored-by: Greg <[email protected]> Co-authored-by: CHANCE <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Johnson <[email protected]> Co-authored-by: Agora Governance Bot <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent several minutes chasing my tail until just going to look onchain and read the registrar logic. The minimum commitment age is enforced as a functional requirement to
commit. Currently the docs mark it as "recommended" however that is not the case.