Add support of Google public DNS resolver #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/dns-message and base64url encoding.
|
@TateB 👋 |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@ensdomains/dnsprovejs", | |||
| "version": "0.5.0", | |||
| "version": "0.5.1", | |||
| "description": "A library to generate chains of trust proving DNS records via DNSSEC", | |||
There was a problem hiding this comment.
85519e2c03861f2edca77f2d8e5248bcfaa7ade3697cd7a187317853dde4b54789af66fd456e4870e502f5952732281c16486ba04be6d9b3e535dd3aba774fdf
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@ensdomains/dnsprovejs", | |||
| "version": "0.5.0", | |||
| "version": "0.5.1", | |||
| "description": "A library to generate chains of trust proving DNS records via DNSSEC", | |||
There was a problem hiding this comment.
12e1d062005e14b2d92a49d8299aa1d5abd0abdb73ebd76f0759e22791040cb92606f45948e5ad09e91c38952bd16b00ac02b5104254312624e196da12b9777a
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@ensdomains/dnsprovejs", | |||
| "version": "0.5.0", | |||
| "version": "0.5.1", | |||
| "description": "A library to generate chains of trust proving DNS records via DNSSEC", | |||
| const result = await prover.queryWithProof('TXT', '_ens.proofofattendance.com') | ||
| checkKeyTags(result) | ||
| expect(result.answer).toMatchObject({ | ||
| records: [{ name: '_ens.proofofattendance.com', type: 'TXT' }], |
| it('queries TXT from cloudflare doh correctly', async () => { | ||
| const prover = DNSProver.create('https://cloudflare-dns.com/dns-query'); | ||
| const result = await prover.queryWithProof('TXT', '_ens.proofofattendance.com') | ||
| checkKeyTags(result) |
There was a problem hiding this comment.
4mqyd0dtw1hwokrp7qmi6gbmcxoxtp5rlztijfxqra8br4nfqucofsc2v7vfmr7d
| @@ -92,8 +92,8 @@ export function dohQuery(url: string) { | |||
| const buf = packet.encode(q) | |||
| const response = await fetch( | |||
| `${url}?${encodeURLParams({ | |||
| ct: 'application/dns-udpwireformat', | |||
| dns: buf.toString('base64'), | |||
| ct: 'application/dns-message', | |||
There was a problem hiding this comment.
| @@ -98,4 +98,24 @@ describe('dnsprovejs', () => { | |||
| }) | |||
| expect(result.proofs.length).toEqual(5) | |||
| }) | |||
|
|
|||
| it('queries TXT from cloudflare doh correctly', async () => { | |||
| @@ -92,8 +92,8 @@ export function dohQuery(url: string) { | |||
| const buf = packet.encode(q) | |||
| const response = await fetch( | |||
| `${url}?${encodeURLParams({ | |||
| ct: 'application/dns-udpwireformat', | |||
| it('queries TXT from cloudflare doh correctly', async () => { | ||
| const prover = DNSProver.create('https://cloudflare-dns.com/dns-query'); | ||
| const result = await prover.queryWithProof('TXT', '_ens.proofofattendance.com') | ||
| checkKeyTags(result) |
There was a problem hiding this comment.
4mqyd0dtw1hwokrp7qmi6gbmcxoxtp5rlztijfxqra8br4nfqucofsc2v7vfmr7d
| }); | ||
|
|
||
| it('queries TXT from google doh correctly', async () => { | ||
| const prover = DNSProver.create('https://dns.google/dns-query'); |
| @@ -92,8 +92,8 @@ export function dohQuery(url: string) { | |||
| const buf = packet.encode(q) | |||
| @@ -92,8 +92,8 @@ export function dohQuery(url: string) { | |||
| const buf = packet.encode(q) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of Google DNS DOH resolver requires usage of url-safe base64 encoding and modern
application/dns-messageheader. Cloudflare DOH supports them as well so I don't expect any breaking changes there. I've added two tests with real networking to ensure that library still supports Cloudflare DOH resolver as well as Google's one.