Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump pre-commit autoupdate #960

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

vorburger
Copy link
Member

@vorburger vorburger commented Dec 10, 2024

In addition to pre-commit autoupdate, this also adds pyjson5 as an additional dependency for the check-jsonschema pre-commit; I'm hoping that this will fix the following error seen (only) on CI (not locally):

Validate Renovate Config.................................................Failed
- hook id: check-renovate
- exit code: 1

Several files failed to parse.
  BadFileTypeError: cannot parse .renovaterc.json5 because support is missing for json5

  check-jsonschema can only parse json5 files when a json5 parser is installed

  If you are running check-jsonschema as an installed python package, either
      pip install json5
  or
      pip install pyjson5

  If you are running check-jsonschema as a pre-commit hook, set
      additional_dependencies: ['json5']
  or
      additional_dependencies: ['pyjson5']

    in "/home/runner/.cache/pre-commit/repothldx688/py_env-python3/lib/python3.12/site-packages/check_jsonschema/instance_loader.py", line 48
    >>> data: t.Any = self._parsers.parse_data_with_path(

I've chosen https://github.com/Kijewski/pyjson5 instead of https://github.com/dpranke/pyjson5 because the former seems to slower than latter with cython.

@vorburger vorburger force-pushed the bump-pre-commit-hooks branch from f944377 to aa12f00 Compare December 10, 2024 23:45
Also add pyjson5 as an additional dependency for check-jsonschema pre-commit;
I'm hoping that this will fix the following error seen (only) on CI (not locally):

Validate Renovate Config.................................................Failed
- hook id: check-renovate
- exit code: 1

Several files failed to parse.
  BadFileTypeError: cannot parse .renovaterc.json5 because support is missing for json5

  check-jsonschema can only parse json5 files when a json5 parser is installed

  If you are running check-jsonschema as an installed python package, either
      pip install json5
  or
      pip install pyjson5

  If you are running check-jsonschema as a pre-commit hook, set
      additional_dependencies: ['json5']
  or
      additional_dependencies: ['pyjson5']

    in "/home/runner/.cache/pre-commit/repothldx688/py_env-python3/lib/python3.12/site-packages/check_jsonschema/instance_loader.py", line 48
    >>> data: t.Any = self._parsers.parse_data_with_path(

I've chosen https://github.com/Kijewski/pyjson5 instead of https://github.com/dpranke/pyjson5 because the former seems to slower than latter with cython.
@vorburger vorburger force-pushed the bump-pre-commit-hooks branch from aa12f00 to a0402c9 Compare December 11, 2024 00:25
@vorburger vorburger merged commit 55935eb into enola-dev:main Dec 11, 2024
5 of 6 checks passed
@vorburger vorburger deleted the bump-pre-commit-hooks branch December 11, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant