Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove use of async-trait for Rust 1.75.0+ #92

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

enmand
Copy link
Owner

@enmand enmand commented Aug 16, 2024

With Rust 1.75.0+, -> impl Trait (including -> impl Future) is supported for Traits, allowing for async trait definitions without the async-trait crate.

Remove use of the async-trait crate, and use Rust's 1.75.0+ features.

https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html

enmand added 2 commits August 14, 2024 14:30
With Rust 1.75.0+, -> impl Trait (including -> impl Future) is supported for
Traits, allowing for async trait definitions without the async-trait crate.

Remove use of the async-trait crate, and use Rust's 1.75.0+ features.

https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (04afe59) to head (a06afdf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files           7        7           
  Lines         190      190           
=======================================
  Hits          159      159           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enmand enmand merged commit 1014d1c into main Aug 16, 2024
9 checks passed
@enmand enmand deleted the chore/no-async-trait branch August 16, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant