-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for naming index bug #223 #226
Conversation
Did you check if other cases like rename and delete are properly updating that map? |
Hi, I just checked for delete and indeed Rename is working properly. I'll fix delete and make sure to test properly before creating new PRs. |
Hi, I've tested correctness of resource name with proper index by both deleting and renaming resources for 3-4 resource types. It's working fine in both cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we're good to go. Anything else from you, fundies?
A small fix for #223 which involves addition of
resourceMap->AddResource(...)
call after resource name creationresourceMap->CreateResourceName
. This call helps to increment index counter when another resource of same type is created.