Skip to content

Commit

Permalink
when table.rows > topn.limit+topn.offset, do not generate topn-filter
Browse files Browse the repository at this point in the history
  • Loading branch information
englefly committed Sep 6, 2024
1 parent 744a1ec commit e1214f1
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,10 @@ public Boolean visitPhysicalNestedLoopJoin(PhysicalNestedLoopJoin<? extends Plan
public Boolean visitPhysicalRelation(PhysicalRelation relation, PushDownContext ctx) {
if (supportPhysicalRelations(relation)
&& relation.getOutputSet().containsAll(ctx.probeExpr.getInputSlots())) {
topnFilterContext.addTopnFilter(ctx.topn, relation, ctx.probeExpr);
return true;
if (relation.getStats().getRowCount() > ctx.topn.getLimit() + ctx.topn.getOffset()) {
topnFilterContext.addTopnFilter(ctx.topn, relation, ctx.probeExpr);
return true;
}
}
return false;
}
Expand Down
40 changes: 40 additions & 0 deletions regression-test/suites/nereids_tpch_p0/tpch/topn_filter.groovy
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

suite("topn_filter") {
String db = context.config.getDbNameByFile(new File(context.file.parent))
sql "use ${db}"
sql "set topn_opt_limit_threshold=1024"
sql "analyze table nation with sync"
// limit + offset > table.rows, do not generate topn filter
explain{
sql "select * from nation order by n_nationkey limit 40;"
notContains ("TOPN OPT:")
}
explain{
sql "select * from nation order by n_nationkey limit 4 offset 21;"
notContains ("TOPN OPT:")
}

explain{
sql "select * from nation order by n_nationkey limit 4 offset 20;"
contains ("TOPN OPT:1")
}

}

0 comments on commit e1214f1

Please sign in to comment.