h18 adjust join left right ignorable diff

englefly · Dec 2, 2023 · bb4e6ba · bb4e6ba
1 parent f42e538
commit bb4e6ba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java
@@ -60,6 +60,7 @@ class CostModelV1 extends PlanVisitor<Cost, PlanContext> {
     static final double BROADCAST_JOIN_SKEW_RATIO = 30.0;
     static final double BROADCAST_JOIN_SKEW_PENALTY_LIMIT = 2.0;
     static final double RANDOM_SHUFFLE_TO_HASH_SHUFFLE_FACTOR = 0.1;
+    static final double JOIN_LEFT_RIGHT_DIFF_IGNORE_THRESHOLD = 10.0;
     private final int beNumber;
 
     public CostModelV1(ConnectContext connectContext) {
@@ -265,11 +266,11 @@ public Cost visitPhysicalHashJoin(
 
         double leftRowCount = probeStats.getRowCount();
         double rightRowCount = buildStats.getRowCount();
-        if (Math.abs(leftRowCount - rightRowCount) < 10) {
+        if (Math.abs(leftRowCount - rightRowCount) < JOIN_LEFT_RIGHT_DIFF_IGNORE_THRESHOLD) {
             int leftConnectivity = computeConnectivity(physicalHashJoin.left(), context);
             int rightConnectivity = computeConnectivity(physicalHashJoin.right(), context);
             if (rightConnectivity < leftConnectivity) {
-                leftRowCount += 10;
+                leftRowCount += JOIN_LEFT_RIGHT_DIFF_IGNORE_THRESHOLD;
             }
 
         }

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/JoinEstimation.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/stats/JoinEstimation.java
@@ -45,7 +45,7 @@
  */
 public class JoinEstimation {
     private static double DEFAULT_ANTI_JOIN_SELECTIVITY_COEFFICIENT = 0.3;
-    private static double UNKNOWN_COL_STATS_FILTER_SEL_LOWER_BOUND = 0.5;
+    private static double UNKNOWN_COL_STATS_FILTER_SEL_LOWER_BOUND = 0.1;
 
     private static EqualPredicate normalizeHashJoinCondition(EqualPredicate equal, Statistics leftStats,
             Statistics rightStats) {