collectionviews: Ignore session state if it uses the wrong format #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmccall
force-pushed
the
T35159-validate-saved-state
branch
2 times, most recently
from
a94375b to
389270b
Compare
dylanmccall
changed the title
wjt
requested changes
Feb 8, 2024
It is possible for COLLECTIONS_STATE to be populated with data from a previous version of kolibri-explore-plugin, which results in unhandled errors in new code which expects it to be in a different format. https://phabricator.endlessm.com/T35159
This view was accessing "name" and "sequence" items in the collection manager state object. These have been renamed to "collection_name" and "collection_sequence". https://phabricator.endlessm.com/T35159
dylanmccall
force-pushed
the
T35159-validate-saved-state
branch
from
389270b to
8542bd1
Compare
wjt
reviewed
Feb 9, 2024
| with ENSURE_INITIATED_RLOCK: | ||
| if _collection_download_manager is None: | ||
| _read_content_manifests() | ||
| return api_function(*args, **kwargs) |
There was a problem hiding this comment.
Is it intentional that the wrapped function is called with the lock held?
IIUC, the lock is meant to ensure that _read_content_manifests() is called only once; so I would expect that the lock could be released before calling the wrapped api_function. But I'm probably wrong!
There was a problem hiding this comment.
Ooh yes, that isn't intentional. Thanks for noticing :)
It is possible for concurrent requests to be served by different threads in the same Python process, resulting in unexpected behaviour if the wrapper function from ensure_initiated is not finished executing for the first time. To solve this, wrap the critical code in a lock. https://phabricator.endlessm.com/T35159
dylanmccall
force-pushed
the
T35159-validate-saved-state
branch
from
d4db24e to
4743786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for COLLECTIONS_STATE to be populated with data from a previous version of kolibri-explore-plugin, which results in unhandled errors in new code which expects it to be in a different format.
https://phabricator.endlessm.com/T35159