863 followup #870
Merged
863 followup #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now consistent: start/update/cancel
Otherwise the UI will attempt a new download in the next session after the download is complete. Helps #863
dbnicholson
approved these changes
Oct 6, 2023
Ouch.. I will have to test further. |
|
It might be OK since I might have been in a funky state while I was doing testing for the caching issue. As in, I cleared all the site data at one point while I was looking at whether the browser was using cached objects or not. That's a big reason why I'd want to store the download state in the database, but it's a pretty niche use case. I'll try again today to see if I can reproduce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #863