Download content pack even when there is content #866
Conversation
| @@ -145,29 +149,26 @@ export function decideWelcome(store) { | |||
|
|
|||
| return Promise.all([getDownloadStatus(), getShouldResume()]).then( | |||
| ([status, { shouldResume, grade, name }]) => { | |||
| if (_isDownloadOngoing(status) || shouldResume) { | |||
| console.log(['MANUQ', status, shouldResume, grade, name]); | |||
There was a problem hiding this comment.
Can you drop or replace this string with something more descriptive?
There was a problem hiding this comment.
Haha, this was a print leftover.
Change the assumption for showing the welcome screens: before, when there was content in the database it was assumed to be already downloaded and the download was skipped. Now rely on the presence of a DOWNLOAD_COMPLETED state persisted. Fix #863
manuq
force-pushed
the
863-content-pack-with-channels
branch
from
f21dd08 to
a935f95
Compare
The routing is a pain. I have checked in latest Kolibri and the situation didn't improve. So Kolibri has a wrapper around vue-router which plugins use passing a routes object. But also Kolibri has a SET_PAGE_NAME and the current page is used to display a different component in the root view (in our case in the ExplorePlugin). And in the same root has a
Yeah.. that was the idea when implementing content packs management (install more packs, remove packs, etc). |
Change the assumption for showing the welcome screens: before, when there was content in the database it was assumed to be already downloaded and the download was skipped. Now rely on the presence of a DOWNLOAD_COMPLETED state persisted.
Fix #863