Added controller support for move block #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjt
requested changes
Dec 16, 2024
There was a problem hiding this comment.
On top of the changes requested below, as mentioned in #337 please fix the linter errors. You can set up and run pre-commit locally as documented in the README.
(For what it's worth, I really don't like how gdformat formats nested dictionaries but that's the price of standardization.)
addons/block_code/simple_nodes/simple_character/simple_character.gd
Outdated
Show resolved
Hide resolved
addons/block_code/simple_nodes/simple_character/simple_character.gd
Outdated
Show resolved
Hide resolved
addons/block_code/simple_nodes/simple_character/simple_character.gd
Outdated
Show resolved
Hide resolved
addons/block_code/simple_nodes/simple_character/simple_character.gd
Outdated
Show resolved
Hide resolved
|
thanks for the review @wjt, I just fixed all the changes so it should be ready for re-review now. |
wjt
requested changes
Dec 17, 2024
addons/block_code/simple_nodes/simple_character/simple_character.gd
Outdated
Show resolved
Hide resolved
addons/block_code/simple_nodes/simple_character/simple_character.gd
Outdated
Show resolved
Hide resolved
|
Thanks for the review @wjt, I just made the relevant changes, so it should be ready for a re-review now. |
Previously, keypresses were detected directly, rather than going through the input map. In preparation for handling multiple input devices for each action, add appropriate entries to the input map at runtime, if not already present. Map each one to the same key as previously.
Map the d-pad and left stick of controllers 0 and 1 to the directional actions of players 1 and 2, respectively, in addition to the keyboard mappings. Fixes: endlessm#257
wjt
force-pushed
the
add_controller_support
branch
from
fd7db2b to
34301a1
Compare
wjt
approved these changes
Dec 17, 2024
Closed
|
@dsd please can you award the bounty to this contributor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #257
I added some Input Actions to the InputMap so that
player_1_upcontains both keyboard and controller events.Player 1 and Player 2 joystick buttons are identical aside from belonging to different devices. (Player 1 = Device 0 and Player 2 = Device 1)