Hooks: Add hook to expose Endless Key launchers in app grid

[cassidyjames]

Is this the right idea? It sort of feels dirty to include a whole shell script here. And do I need to make it executable?

https://phabricator.endlessm.com/T35614

[wjt]

It doesn't need to be executable. If you look at the other files in this directory, only the ones ending in .chroot are executable. That's because they are run in a different environment, by chrooting into the target image, and then invoking them as a program. The non-chroot ones are sourced with the . operator.

[wjt]

I agree that it's a little ugly to write a shell script to write an embedded shell script to a place, but for better or for worse that's how it's done for now.

You could imagine instead putting the file in the OS, and then just making a symlink here. But I think this is OK.

[dbnicholson]

This feels like the kind of thing that should be in the OS. In fact, we already have this exact thing for regular Kolibri.

[cassidyjames]

I threw a test build at Jenkins, and it errored out with:

++ 21:07:53 54-ek-launchers: cat
/tmp/image-build-PJzO8VoBgE/eos-image-builder/hooks/image/54-ek-launchers: line 3: /var/cache/eos-image-builder/tmp/ostree-co/ostree/deploy/eos/deploy/18fedf9dcbf070e57e12ff5a93621573349ee8276dbc9717629fbb52f295df56.0/etc/systemd/user-environment-generators/62-endless-key.sh: No such file or directory

[dylanmccall]

This feels like the kind of thing that should be in the OS. In fact, we already have this exact thing for regular Kolibri.

Indeed, another approach here is we change eos-kolibri to also build its own 61-eos-endless-key.sh environment generator right there, but in that one we add a test at the beginning, maybe for an environment variable or for a file like /var/lib/endless-key/data/content/xdg/show-launchers. The image builder hook would just need to add that one thing to satisfy the test. Less code that we can't update :)

I'm not too bothered by this implementation, but I'm curious if this is going to be needed for a lot of images, or if it's just a one-off?