Remove desktop branding hook #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are removing eos-watermark-extension. It is very lightly used, not enough to justify updating it for GNOME 43 compatibility. If we wish to bring this functionality back in future, we should instead package https://pagure.io/background-logo-extension, which is actually the ancestral source of the eos-watermark-extension code and which is actively maintained by a core Shell developer for each Fedora release. In that case, we would use GSettings overrides rather than this gnome-shell.conf INI file to set the logo path. https://phabricator.endlessm.com/T35077
manuq
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka watermark support,We are removing eos-watermark-extension. It is very lightly used, not
enough to justify updating it for GNOME 43 compatibility.
If we wish to bring this functionality back in future, we should instead
package https://pagure.io/background-logo-extension, which is actually
the ancestral source of the eos-watermark-extension code and which is
actively maintained by a core Shell developer for each Fedora release.
In that case, we would use GSettings overrides rather than this
gnome-shell.conf INI file to set the logo path.
https://phabricator.endlessm.com/T35077