eibkolibri: Follow channel update with channel import #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If new nodes are added in a new channel version, the channel needs to be updated or they will be skipped if they're below an already existing node. However, if there are missing nodes from a previously failed import, then a regular import is needed. Therefore, follow a channel update with a channel import. The update is run first because the algorithm for calculating newly needed nodes depends on comparing the old and new versions of the channel metadata. One a regular import is done, the old version of the channel metadata is replaced and the calculation can't be made anymore. https://phabricator.endlessm.com/T34697
wjt
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If new nodes are added in a new channel version, the channel needs to be updated or they will be skipped if they're below an already existing node. However, if there are missing nodes from a previously failed import, then a regular import is needed. Therefore, follow a channel update with a channel import.
The update is run first because the algorithm for calculating newly needed nodes depends on comparing the old and new versions of the channel metadata. One a regular import is done, the old version of the channel metadata is replaced and the calculation can't be made anymore.
https://phabricator.endlessm.com/T34697