endlesskey: Import only specified content in collections #141
Conversation
The previous behaviour, of importing all content from all channels in the collections, is preserved by setting include_full_channels to true. https://phabricator.endlessm.com/T35103
| curious | ||
| explorer | ||
| inventor | ||
| scientist |
There was a problem hiding this comment.
I think you want to also include extras or this won't work offline. The explore plugin will try to import all the thumbnails from nodes in the extras pack at runtime. See https://github.com/endlessm/kolibri-explore-plugin/blob/master/kolibri_explore_plugin/collectionviews.py#L43. I think it's fine to import whatever nodes are specified in it.
There was a problem hiding this comment.
Oh yeah, that's a good one. I pushed a change just now (4583308) getting it to download all thumbnails for all the included channels.
Alas, adding the extras collection is a bit problematic, since that manifest file includes a bunch of content as well. But it probably shouldn't? I proposed endlessm/endless-key-collections#37 just now to address that, and then I can add it here.
There was a problem hiding this comment.
The collections change was merged, released, and included in an org.endlessos.Key flathub release. So, I think this should be good now.
dylanmccall
force-pushed
the
T35103-endless-key-collections
branch
from
7154636 to
75060ae
Compare
dylanmccall
force-pushed
the
T35103-endless-key-collections
branch
from
75060ae to
4583308
Compare
| curious | ||
| explorer | ||
| inventor | ||
| scientist |
There was a problem hiding this comment.
The collections change was merged, released, and included in an org.endlessos.Key flathub release. So, I think this should be good now.
| kolibri manage --skip-update \ | ||
| importcontent --include-unrenderable-content --fail-on-error \ | ||
| --node_ids="" --all-thumbnails \ | ||
| network "${channel}" |
There was a problem hiding this comment.
IMO, this should only be in the not full channels branch below. The full channels branch is obviously already going to import all the thumbnails. Not a big deal, though.
The previous behaviour, of importing all content from all channels in the collections, is preserved by setting include_full_channels to true.
https://phabricator.endlessm.com/T35103