Add human-readable names & summaries to Flatpak manifest #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjt
commented
Nov 10, 2023
wjt
force-pushed
the
T35013-add-appstream-name-and-summary-to-manifest
branch
from
fcd9609 to
a3e53cc
Compare
Move the main body of this script into a main() function, in advance of factoring more sections out of it. https://phabricator.endlessm.com/T35013
There is a common subset of keys being exported for installed apps and runtimes alike. Factor this out into a function, so we can export even more data. https://phabricator.endlessm.com/T35013
wjt
force-pushed
the
T35013-add-appstream-name-and-summary-to-manifest
branch
from
a3e53cc to
7ea457c
Compare
|
Triggered https://ci.endlessos.org/job/image-build-arm64/6341 to test this |
cassidyjames
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Can confirm I get the correct output in the manifest linked at https://images.endlessos.org/builds/13078/. Nice work!
dbnicholson
deleted the
T35013-add-appstream-name-and-summary-to-manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35013
(I have another branch on the way to export a complete appstream catalogue for pre-installed apps but that one is rather slower to test.)