Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Install Endless Key by default #122

Merged
merged 2 commits into from
Oct 17, 2023
Merged

config: Install Endless Key by default #122

merged 2 commits into from
Oct 17, 2023

Conversation

dbnicholson
Copy link
Member

I think we want this installed by default for basically all images, although images that want preloaded content should also explicitly add it. For now I left org.learningequality.Kolibri preinstalled.

@dsd
Copy link
Member

dsd commented Oct 17, 2023

How much hassle would it be to remove Kolibri from the base config, but readd it in all the configs where Kolibri channels are installed?
(In general we are going to shift away from plain Kolibri to Endless Key as our content shipping solution)

@dbnicholson
Copy link
Member Author

How much hassle would it be to remove Kolibri from the base config, but readd it in all the configs where Kolibri channels are installed? (In general we are going to shift away from plain Kolibri to Endless Key as our content shipping solution)

Not too much as most of them already do. I started looking at that but punted. It will need a companion change in endless-image-config.

@dbnicholson
Copy link
Member Author

How much hassle would it be to remove Kolibri from the base config, but readd it in all the configs where Kolibri channels are installed? (In general we are going to shift away from plain Kolibri to Endless Key as our content shipping solution)

Not too much as most of them already do. I started looking at that but punted. It will need a companion change in endless-image-config.

https://github.com/endlessm/endless-image-config/pull/1157

We want Endless Key to be the default application handling Kolibri
content. Any images that want to use the Kolibri app should explicitly
add it.
@dbnicholson
Copy link
Member Author

I added a commit to remove the default Kolibri flatpak install.

@dsd dsd merged commit 25d554e into master Oct 17, 2023
2 checks passed
@dsd dsd deleted the endless-key-default branch October 17, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants