Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: Don't resend command after reconnecting due to READONLY #16

Merged

Conversation

wjt
Copy link
Member

@wjt wjt commented Sep 30, 2024

I made a local change to reconnectOnError() to return 2 to test the behaviour. I then described in the comment why I thought that it would be better not to do that, but forgot to change the 2 back to 1 or true.

Fixes commit a755997.

https://phabricator.endlessm.com/T35146

I made a local change to reconnectOnError() to return `2` to test the
behaviour. I then described in the comment why I thought that it would be
better not to do that, but forgot to change the `2` back to `1` or `true`.

Fixes commit a755997.

https://phabricator.endlessm.com/T35146
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@dbnicholson dbnicholson merged commit 8b61db5 into master Sep 30, 2024
1 check passed
@dbnicholson dbnicholson deleted the T35146-dont-resend-after-reconnecting-due-to-readonly branch September 30, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants