You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new runModeFor method is introduced in SideEffect, with the default set to Async to ensure backward compatibility. With Async mode, it triggers in run & forget mode so that any lengthy side-effect does not delay command reply. With Sync mode, the side-effect runs to completion before the entity processes the next command: this can simplify the side-effect logic as it precludes accounting for concurrency, but can hurt the system's responsiveness.
Additional Import and Method Update in DurableShardedEntityDeployer.scala and EventSourcedShardedEntityDeployer.scala
They now include the import endless.core.entity.SideEffect.RunMode, which provides rules for running specific types of operations in our system. The methods for handling side effects were also updated to take more parameters and deal with them depending on the RunMode.
Added runModeFor in SideEffect.scala
A new method runModeFor is now in SideEffect.scala. This method will be used to inquire about the run mode of specific operations.
Documentation Update
Updated the documentation in side-effect.md to include the new changes.
Removal of Unused Imports
Unnecessary matching imports were removed from a number of files to streamline the code and mitigate any issues they may cause.
Scala Version Update
The application's Scala version has been updated to 2.13.14 for enhanced performance and new feature availability.
Change in System Shutdown Behaviour
Added coordinated-shutdown.exit-jvm = off in akka.conf and pekko.conf. This indicates that the system will not forcibly terminate the JVM during a coordinated shutdown.
Test Case Refactors
Adjusted the munitFixtures to use IOFixture in several testing suites. This change is aimed at making tests more robust and reliable.
A new `runModeFor` method is introduced in `SideEffect`, with the default set to `Async` to ensure backward compatibility. With `Async` mode, it triggers in *run & forget* mode so that command reply is not delayed by any lengthy side-effect. With `Sync` mode, the side-effect runs to completion before the next command is processed by the entity: this can be useful to simplify the side-effect logic as it precludes accounting for concurrency, but can hurt the system's responsiveness.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jchapuis
force-pushed
the
side-effect-mode
branch
from
A new
runModeFormethod is introduced inSideEffect, with the default set toAsyncto ensure backward compatibility. WithAsyncmode, it triggers in run & forget mode so that any lengthy side-effect does not delay command reply. WithSyncmode, the side-effect runs to completion before the entity processes the next command: this can simplify the side-effect logic as it precludes accounting for concurrency, but can hurt the system's responsiveness.