Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary actor system termination in example apps #304

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

jchapuis
Copy link
Member

@jchapuis jchapuis commented Feb 7, 2024

It's already handled by AkkaCluster/PekkoCluster managed resources

It's already handled by AkkaCluster/PekkoCluster managed resources
@endless4s endless4s deleted a comment from what-the-diff bot Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa1ba0f) 89.73% compared to head (4af1ebf) 89.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   89.73%   89.61%   -0.12%     
==========================================
  Files          73       73              
  Lines         877      867      -10     
  Branches       94       98       +4     
==========================================
- Hits          787      777      -10     
  Misses         90       90              
Files Coverage Δ
.../main/scala/endless/example/app/akka/AkkaApp.scala 100.00% <100.00%> (ø)
...ain/scala/endless/example/app/pekko/PekkoApp.scala 100.00% <100.00%> (ø)
...la/endless/runtime/pekko/deploy/PekkoCluster.scala 92.30% <ø> (ø)

@jchapuis jchapuis merged commit 0f1d20a into master Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant