Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add animation option to setPage() method for Android #251

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

moazelsawaf
Copy link
Contributor

Hi there πŸ‘‹πŸ»

Thank you for making and maintaining this awesome plugin, which is helping the Flutter community grow more and more πŸ’™

In this pull request, I have added an animation option to the setPage() method for Android. This allows users to jump to the required page with a transition animation βœ…

Here are some details about the feature:

  • The feature is currently only supported for Android, as the native iOS dependency does not provide an option for this.
  • The feature has been documented in the README file and inside the code with Dart doc comments.
  • The feature can be enabled or disabled by a parameter called withAnimation in the setPage() method. The default value is false.
  • The feature has been implemented with backward compatibility in mind, so there are no breaking changes. The new parameter has been added as an optional parameter after the old required positional one.

I hope you like this feature! πŸ’™

Thanks πŸ™πŸ»πŸ’™

upgrade `build.gradle` file to match the latest Flutter SDK version at the time of commit
@moazelsawaf
Copy link
Contributor Author

Hi @endigo πŸ‘‹πŸ»

It has been a long time since this PR, can you please review it and give me your feedback πŸ™πŸ»

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant