aded support: spacing, enableDoubletap, setBackgroundColor (only android for now), onTap callback, zoom parameters (min, mid, max) #173
Conversation
lcyper
changed the title
lcyper
changed the title
lcyper
changed the title
| /// for double tap (middle step) | ||
| final double setMidZoom; | ||
|
|
||
| /// Works on [Android] |
There was a problem hiding this comment.
Plans to get this functional on iOS?
I recently opened #210 to address the unwanted default zoom of the PDFView build, but I am not experienced in Swift to develop a fix myself, yet.
| final Color setBackgroundColor; | ||
|
|
||
| /// Works on [Android] | ||
| final double setMaxZoom; |
There was a problem hiding this comment.
yes, you founded in the other file.
| _pdfView.minScaleFactor = _pdfView.scaleFactorForSizeToFit; | ||
| _pdfView.maxScaleFactor = 4.0; | ||
| _pdfView.maxScaleFactor = [args[@"setMaxZoom"] doubleValue]; // 4.0; |
There was a problem hiding this comment.
Not proficient in this language, but does this code here fulfill the parameters setZoom for iOS and you just forgot to update the doc comments on flutter_pdfview.dart?
There was a problem hiding this comment.
aded support:
spacing between pages,
enableDoubletap, (to enable zoom)
setBackgroundColor (only android for now),
onTap callback, (to add custom functionality)
zoom parameters (min, mid, max)
correct description:aded support:
|
|
@endigo This PR adds value to the package. What is preventing it from being approved? |
|
@endigo I sent a message 18 days ago and am still facing the same question. I have an application to demo in 1 week that depends on this repository. It would be helpful to merge this PR for a more sophisticated UX. At a minimum, I am requesting that the setZoom be added: (as done in this commit) Thank you for contributing to the open-source community. |
|
@endigo When will be merged this PR? |
also i upgraded gradle versions