Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [513] added loading state to async buttons #526

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

DCH25
Copy link
Contributor

@DCH25 DCH25 commented Apr 12, 2023

Details

  • Added loading state to buttons which make async requests

Closes #513

@JoelWiebe
Copy link
Contributor

Details
For some reason most error messages were not displaying for me. Perhaps missing some latest changes. I have left my suggestions below. In each case I have throttling turned off while navigating to the appropriate view, then set my browser network settings to offline.

Tasks

  • When updating the Board Configurations while offline, I am getting the following error (shown below). Could we simplify this message for the user (to also be consistent with Ammar's previous Add Post error message): "Unable to update board configurations. Please refresh and try again!"
Screenshot 2023-07-05 at 11 13 44 AM
  • For the board configurations, if I turn the browser offline either before I open the project modal or after I open the project modal then press the Update button, the button either spins and closes (without an error message) or spins indefinitely (without an error message). Can we ensure the following message is being displayed: "Unable to update board configurations. Please refresh and try again!"

  • On the Add Post modal, I am able to add a tag to the post and there is no error. Can we (1) have the tag fail to be visually added to the post (as with the View Post modal) and (2) ensure the following error message is displayed when the user clicks to add a tag: "Unable to add tag. Please refresh and try again!"

  • When the tag fails to be added in the View Post modal, can we display the error message: "Unable to add tag. Please refresh and try again!"

  • When editing the title or the message of a post, when the Update button is pressed after editing the title or message, can we display an error message: "Unable to update post. Please refresh and try again!"

@DCH25 Perhaps we've been using different means of simulating latency or network issues. Please let me know if you have any questions or would like to discuss anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Latency Issues for UI Controls
2 participants