Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 313 - Blank tag logs for un-submitted posts #315

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zarifmahmud
Copy link
Contributor

Details

  • Fixes bug where tags added during post creation weren't being added to the trace logs.

Closes #313

@zarifmahmud zarifmahmud added the Ready for review 👀 PR is complete and ready to be reviewed label Jul 6, 2022
@LunarFang416
Copy link
Contributor

LunarFang416 commented Jul 6, 2022

@zarifmahmud Just tested this out. When a post is created on the canvas, the tags that are added when creating the post are logged like we want, so it works fine there. But when you create a post inside a bucket, the tags aren't logged. I think you may just have to emit the POST_TAG_ADD event from there as well.

@JoelWiebe JoelWiebe requested a review from a team July 9, 2022 15:45
@JoelWiebe
Copy link
Contributor

@LunarFang416 Thanks for reviewing. @zarifmahmud please let me know once this is updated and I'll check it out then :)

@zarifmahmud
Copy link
Contributor Author

Should be ready to go now!

Copy link
Contributor

@JoelWiebe JoelWiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, for some reason I'm still not getting any tags showing up in logs from a bucket

Tested:

  1. Created a board
  2. Created a bucket
  3. Open the editor for a new post in the new bucket
  4. Clicked on one of the default tags
  5. Wrote a title
  6. Added the posts
  7. Downloaded the CSV file from the project dashboard

For some reason I'm still getting no tags logged in the trace logs. Additionally, I'm noticing that there isn't even a log for the post being created (there should be a Post_Create event for the creation of the post and Post_Tag_Add events for each of the tags.

If there is anything I can further clarify, please let me know. Maybe we can have a quick call sometime!

Screen Shot 2022-07-15 at 12 05 51 AM

Screen Shot 2022-07-15 at 12 07 00 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review 👀 PR is complete and ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank tag logs for un-submitted posts
4 participants